Bug 1237904 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Ah yeah. I think that was actually unintentional and we might want to revert to the old behavior of not showing stacks. But as long as we don't get any leaks, maybe we are good? 

I think most likely the behavior change was in this area: https://hg.mozilla.org/integration/autoland/rev/58bcc2778e01#l12.38
Before we would not keep the stack for mWindowID = 0. Now we probably call CreateScriptError and aWin is nullptr so we do keep the stack, because we get the WindowID.
Revision 1 by
on 
Ah yeah. I think that was actually unintentional and we might want to revert to the old behavior of not showing stacks. But as long as we don't get any leaks, maybe we are good? 

I think most likely the behavior change was in this area: https://hg.mozilla.org/integration/autoland/rev/58bcc2778e01#l12.38
Before we would not keep the stack for mWindowID = 0. Now we probably call CreateScriptError and aWin is nullptr so we do keep the stack, because we can't get the WindowID.

Back to Bug 1237904 Comment 9