Bug 1384260 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

GetForegroundWindow and GetClassNameW are apparently limited to windowed plugins, which we thought were somehow sneaking into runs because we saw them in telemetry but I believe I've confirmed that's not really the case (see Bug 1296400).  GetForegroundWindow still gets run but it always returns NULL (which is weird -- is that due to the current content sandbox?).  So it has been just using that null to skip the fullscreen stuff.  All of this can apparently just be removed.

The RegisterWindowMessage call is always done as part of plugin setup so no STR is really needed.

The SystemParamtersInfo calls happen on any horizontal or vertical scroll-wheel motion over a plugin.

I'm still verifying the GetKeyState stuff.
GetForegroundWindow and GetClassNameW are apparently limited to windowed plugins, which we thought were somehow sneaking into runs because we saw them in telemetry but I believe I've confirmed that's not really the case (see Bug 1296400).  GetForegroundWindow still gets run (STR: ctrl-tab away, then ctrl-tab back) but it always returns NULL (which is weird -- is that due to the current content sandbox?).  So it has been just using that null to skip the fullscreen stuff.  All of this can apparently just be removed.

The RegisterWindowMessage call is always done as part of plugin setup so no STR is really needed.

SystemParamtersInfo STR is "any horizontal or vertical scroll-wheel motion over a plugin".

I'm still verifying the GetKeyState stuff.

Back to Bug 1384260 Comment 4