Bug 1646857 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Simplify nested conditionals with early returns for a more readable code flow with less indentation levels.
This rewrite should not change the current code logic or behaviour in any way.

It's now much clearer that the first section is shared and will always run, whereas the entire second section will only run for `startup = false`.

Do we even need to check if identityElement (#msgIdentity) is available?
I am not aware of any situation where that could be missing, because if it is, composition would be seriously broken. I'd guess that even addons would rather keep and manipulate the existing element.
Simplify nested conditionals with early returns for a more readable code flow with less indentation levels.
This rewrite should not change the current code logic or behaviour in any way.

Please note that apart from touching a few lines to convert a few conditions into early returns, and the resulting changes in whitespace/indentation levels, I have not changed any other code in between. So it's a diff artifact which creates a false impression as if the whole code had changed.

It's now much clearer that the first section is shared and will always run, whereas the entire second section will only run for `startup = false`.

Do we even need to check if identityElement (#msgIdentity) is available?
I am not aware of any situation where that could be missing, because if it is, composition would be seriously broken. I'd guess that even addons would rather keep and manipulate the existing element.

Back to Bug 1646857 Comment 2