Bug 1691426 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

After the patch landed, I've been looking at if it had an effect. It seems inconclusive from just looking at a comparison between the previous mozilla-central push and the one for the patch (it actually gets worse) but looking at trends it seems more positive:

https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=0&highlightChangelogData=1&highlightedRevisions=916497e295fe&highlightedRevisions=b422dd886e03&series=mozilla-central,2895566,1,13&series=autoland,2891495,1,13&timerange=2592000
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightedRevisions=916497e295fe&highlightedRevisions=b422dd886e03&series=mozilla-central,2895651,1,13&series=autoland,2891544,1,13&timerange=2592000
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightedRevisions=916497e295fe&highlightedRevisions=b422dd886e03&series=mozilla-central,2895649,1,13&series=autoland,2891542,1,13&timerange=2592000

These plots show the trends (with both mozilla-central and autoland plotted) on the three tests from this bug's alert. And it does look like it has trended down around the time the patch landed (especially in autoland), but it's hard to tell exactly.

I'm not sure if that means it is important enough for an uplift. Do you have any thoughts on this Ryan?
After the patch landed, I've been looking at if it had an effect. It seems inconclusive from just looking at a comparison between the previous mozilla-central push and the one for the patch (it actually gets worse) but looking at trends it seems more positive:

https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=0&highlightChangelogData=1&highlightedRevisions=916497e295fe&&highlightedRevisions=0b260a20b5834&highlightedRevisions=b422dd886e036&highlightedRevisions=287db0596e0b0&series=mozilla-central,2895566,1,13&series=autoland,2891495,1,13&timerange=2592000
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightedRevisions=916497e295fe&&highlightedRevisions=0b260a20b5834&highlightedRevisions=287db0596e0b0&highlightedRevisions=b422dd886e036&series=mozilla-central,2895651,1,13&series=autoland,2891544,1,13&timerange=2592000
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightedRevisions=916497e295fe&&highlightedRevisions=0b260a20b5834&highlightedRevisions=287db0596e0b0&highlightedRevisions=b422dd886e036&series=mozilla-central,2895649,1,13&series=autoland,2891542,1,13&timerange=2592000

(relevant revisions like the original alert, and autoland/central pushes with the patch highlighted)

These plots show the trends (with both mozilla-central and autoland plotted) on the three tests from this bug's alert. And it does look like it has trended down around the time the patch landed (especially in autoland), but it's hard to tell exactly.

I'm not sure if that means it is important enough for an uplift. Do you have any thoughts on this Ryan?

Back to Bug 1691426 Comment 18