1223225 - Use channel.asyncOpen2() in browser/base/content/nsContextMenu.js

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1223225_asyncopen2_nscontetxtmenu.patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8685183 [details] [diff] [review]
bug_1223225_asyncopen2_nscontetxtmenu.patch

Review of attachment 8685183 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/nsContextMenu.js
@@ +1350,5 @@
>      var channel = ioService.newChannelFromURI2(makeURI(linkURL),
>                                                 null, // aLoadingNode
>                                                 principal, // aLoadingPrincipal
>                                                 null, // aTriggeringPrincipal
> +                                               Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL,

Should we change this to
NetUtil.newChannel({
  uri: MakeURI(linkURL),
  loadingPrincipal: principal,
  securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL
};

?

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1223225_asyncopen2_nscontetxtmenu.patch

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0080bcc1cecc

Comment 5

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b311176b6354995c31b7cb761323f9566493e71
Backed out changeset 0080bcc1cecc (bug 1223225) for Windows 8 PGO bc1 bustage ON A CLOSED TREE

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81bbe70cc460

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81bbe70cc460