561150 - GetAccessibleInWeakShell should return nsAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 440822 [details] [diff] [review]
patch

>--- a/accessible/src/base/nsDocAccessible.cpp
>+++ b/accessible/src/base/nsDocAccessible.cpp
>@@ -2124,18 +2124,20 @@ nsDocAccessible::GetAccessibleInParentCh
>       break;
>     }
> 
>     nsCOMPtr<nsIDOMNode> relevantNode;
>     if (NS_SUCCEEDED(GetAccService()->GetRelevantContentNodeFor(currentNode, getter_AddRefs(relevantNode))) && relevantNode) {
>       currentNode = relevantNode;
>     }
>     if (aCanCreate) {
>-      GetAccService()->GetAccessibleInWeakShell(currentNode, mWeakShell, 
>-                                                aAccessible);
>+      nsRefPtr<nsAccessNode> acc =
>+        GetAccService()->GetAccessibleInWeakShell(currentNode, mWeakShell);
>+      if (acc)
>+        CallQueryInterface(acc, aAccessible);

I'm not sure why you create an nsAccessNode variable here?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)

> I'm not sure why you create an nsAccessNode variable here?

misspelling, not difference however, will fix it

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 440822 [details] [diff] [review]
patch

r=me then :)

Comment 4

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/4e008ffe35aa