1002514 - Highlight ghost window entry in red if it is non-zero

Status: RESOLVED WONTFIX

(Toolkit :: about:memory, defect)

Description

[Andrew McCreight [:mccr8]]

It would be nice if the "ghost-windows" number at the bottom gets highlighted in red if it is non-zero, as this is usually a sign of badness.  It is fine if you think we should just leave red as a sign of internal inconsistency, like negative values.

Comment 1

[Andrew McCreight [:mccr8]]

Also we could highlight the entire about:memory page in red. ;)

Comment 2

[Nicholas Nethercote [inactive]]

It's an interesting idea but I'm not sure how to implement it. I absolutely don't want to hardwire special treatment of "ghost-windows" in aboutMemory.js -- I've been removing hardwiring of that sort over time and am very happy about it.

So there would have to be a way, when making a report, to flag that a particular measurement should be highlighted if it has a certain value... which isn't easy, because there are so many places making reports.

Comment 3

[Nathan Froyd [:froydnj]]

We have this closure object being passed around to CollectReports, could we ask it whether it supports nsIImportantMeasurementFlagger, and then call some method on it when we have an "unusual" measurement?

Comment 4

[Andrew McCreight [:mccr8]]

I don't think anybody cares enough to fix this.