1005120 - Removing the osfile.jsm import from AppsUtils breaks B2G emulator builds

Status: RESOLVED DUPLICATE of bug 1039861

(Toolkit Graveyard :: OS.File, defect)

Description

[Marco Castelluccio [:marco]]

In bug 981085 we migrated away from OS.File in dom/apps code. AppsUtils.jsm is no longer using OS.File, but removing the osfile.jsm import makes the b2g emulator build fail with the following error:

18:05:26     INFO -  Diagnostic: TypeError: "toString" is read-only at resource://gre/modules/osfile/osfile_unix_allthreads.jsm:89

I'm experiencing the same problem in bug 916874. The test "test_webappsActor.js" that I'm trying to enable is failing probably because of the same error.

Comment 1

[[:fabrice] Fabrice Desré]

That's also preventing me from landing bug 993282

Comment 2

[[:fabrice] Fabrice Desré]

Bobby, it seems that modules loaded with require() behave differently using than Cu.import() only on b2g, so it's probably due to the reuseGlobal thing. Does that ring a bell to you?

Comment 3

[Bobby Holley (:bholley)]

I've never seen this require() setup in our module code before. Is this some devtools thing?

Comment 4

[[:fabrice] Fabrice Desré]

Yes, devtools code uses that *a lot*. And it seems like that makes the devtool "modules" to not be in the same compartement even on b2g. See for instance the memory reports from bug 998145.

Comment 5

[Bobby Holley (:bholley)]

(In reply to Fabrice Desré [:fabrice] from comment #4)
> Yes, devtools code uses that *a lot*. And it seems like that makes the
> devtool "modules" to not be in the same compartement even on b2g. See for
> instance the memory reports from bug 998145.

Oh yeah, yuck. That's totally not going to work with the b2g setup. :-(

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Bobby Holley (:bholley) from comment #5)
> (In reply to Fabrice Desré [:fabrice] from comment #4)
> > Yes, devtools code uses that *a lot*. And it seems like that makes the
> > devtool "modules" to not be in the same compartement even on b2g. See for
> > instance the memory reports from bug 998145.
> 
> Oh yeah, yuck. That's totally not going to work with the b2g setup. :-(

Any hope of doing something, or are we totally fucked up?

Comment 7

[Bobby Holley (:bholley)]

(In reply to Fabrice Desré [:fabrice] from comment #6)
> (In reply to Bobby Holley (:bholley) from comment #5)
> > (In reply to Fabrice Desré [:fabrice] from comment #4)
> > > Yes, devtools code uses that *a lot*. And it seems like that makes the
> > > devtool "modules" to not be in the same compartement even on b2g. See for
> > > instance the memory reports from bug 998145.
> > 
> > Oh yeah, yuck. That's totally not going to work with the b2g setup. :-(
> 
> Any hope of doing something, or are we totally fucked up?

I think the answer here is to hit near-memory-parity with compartments, and kill the funky b2g setup in bug 989373.

Comment 8

[James Zhang (Spreadtrum)]

Can we remove it for tarako only?

Comment 9

[[:fabrice] Fabrice Desré]

(In reply to James Zhang from comment #8)
> Can we remove it for tarako only?

No, that's actually breaking builds we run tests on.