1007285 - Length property of the (Weak){Map,Set} constructors should be 1

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Florian Scholz (Open Web Docs)]

+++ This bug was initially created as a clone of Bug #975412 +++

From the April 27, 2014 Draft Rev 24 ECMAScript specification change list:

"* Changed length property value of Symbol, Map, Set, WeakSet, WeakMap to *1* to be consistent with most other built-in constructors"

With that, changes made in bug 975412 need to be 1 instead of 0.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: collectionlength.patch

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8419300 [details] [diff] [review]
collectionlength.patch

Review of attachment 8419300 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

::: js/src/jit-test/tests/collections/WeakMap-surfaces.js
@@ +27,5 @@
> +    assertEq(desc.value.length, arity);
> +}
> +
> +// XXX: WeakMap#get implementation has an undocumented 2nd argument
> +//checkMethod("get", 1);

Ah, yes. I filed bug 1009349 to get rid of this useful feature.

Comment 3

[Jeff Walden [:Waldo]]

Tell us what you really think.  :-D

Comment 4

[Arpad Borsos [:Swatinem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2e131ffc437

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2e131ffc437

Comment 6

[Florian Scholz (Open Web Docs)]

References updated. Thanks Arpad.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakSet#Properties
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap#Properties
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map#Properties
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set#Properties