1010288 - Searching in all files in the debugger should happen on the server side

Status: RESOLVED WONTFIX

(DevTools :: Debugger, enhancement, P5)

Description

[Victor Porof [:vporof][:vp]]

What we do now:
1. A wild global search appears
2. Fetch all sources' text
3. Do the search
4. Display results.

This is dumb. 

What we should do:
1. A wild global search appears
2. Send the search term to the server
3. Server does the search and sends a list of matches (with the line text, match regions and everything) to the frontend.
4. Display results.

Comment 1

[Girish Sharma [:Optimizer]]

(In reply to Victor Porof [:vporof][:vp] from comment #0)
> 3. Server does the search and sends a list of matches (with the line text,
> match regions and everything) to the frontend.
You might wanna limit the line length, as for minified files, it would mean fetching the whole source ...

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Using a long string actor would be fine. You'd get more than you'd need in the initial packet. If a string wasn't long enough to be a long string actor, then you'd just get the string itself.

Comment 3

[Hallvord R. M. Steen [:hallvors]]

Right now, line number reference is not updated if the source is pretty printed after the match is found. In other words:

0) Enable automatic pretty-printing
1) Do global search for something on a site with minified scripts.
2) Click an entry in the search results - one that shows a match in a minified file

Clicking the entry jumps to the wrong place in the file entirely. Re-typing the search gets the new (post-pretty-printing) line number right and clicking it again goes to the right place.

Would this be fixed by doing the search server-side, or is this better handled as a separate bug? If the latter, is it reported?

Comment 4

[Jason Laster [:jlast]]

I am currently happy with our project search perf, but it could probably still be improved if someone wants to take a stab at this.

Comment 7

[Hubert Boma Manilla (:bomsy)]

Closing this. We are doing project search on the client which ok atm so we don't have plans to move it to the server side atm.