1016577 - Update about:rights content for Geolocation service similar to Toolkit bug 514817

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #844098 +++

Bug Bug 477718 implemented Safe Browsing in SeaMonkey. We should update about:rights to reflect this. Toolkit Bug 514817 has some useful strings we can adapt from e.g.: <snip>

(Quoting rsx11m from bug 844098 comment #2)
> (2) Firefox has another section for Location Aware Browsing on how to flip
> geo.enabled; do we want that as well? (I'm tempted to open a new bug to
> expose that pref in the Privacy & Security pane, in which case the
> instructions on hacking about:config can be avoided, which shouldn't go into
> a generic page).

(Quoting rsx11m from bug 844098 comment #3)
> Re (2), that UI extension is up for review in bug 994093 but depends on bug
> 903439 being solved, which seems to have stalled. Thus, I'll not defer this
> bug here further to wait for Geolocation UI to become available but just go
> with the Safe Browsing additions as initially filed. Once the Location Aware
> Browsing part is working for SeaMonkey again and enabled for releases it
> should be straight-forward to just add those few strings in a follow-up bug.

This is that follow-up bug. Thus, once bug 903439 is resolved, about:rights can be extended with the remaining items from bug 514817:

<!-- location aware browsing points for branded builds -->
<!ENTITY rights.locationawarebrowsing-a "Location Aware Browsing: ">
<!ENTITY rights.locationawarebrowsing-b "is always opt-in.  No location information is ever sent without your permission.  If you wish to disable the feature completely, follow these steps:">
<!ENTITY rights.locationawarebrowsing-term1a "In the URL bar, type ">
<!ENTITY rights.locationawarebrowsing-term1b "about:config">
<!ENTITY rights.locationawarebrowsing-term2 "Type geo.enabled">
<!ENTITY rights.locationawarebrowsing-term3 "Double click on the geo.enabled preference">
<!ENTITY rights.locationawarebrowsing-term4 "Location-Aware Browsing is now disabled">

with respective changes if/when bug 994093 has landed to consider the new pref UI.

Comment 1

[rsx11m]

Now that bug 1271091 has exposed this on release builds as well, we can finally get this done.

Comment 2

[rsx11m]

Tracking protection is disabled by default, thus I'd think that we don't need instructions how to disable it (though technically it's a "web-based information service"). Firefox doesn't list it on their about:rights page either.

Comment 3

[rsx11m]

Attachment: Proposed patch

This patch adds instructions for disabling Geolocation service in the new prefpane UI. It also updates the introductory paragraph a bit, given that there are web-services which are enabled by default and others aren't, thus being more explicit which ones start off enabled.

Comment 4

[Ian Neal]

Comment on attachment 8768974 [details] [diff] [review]
Proposed patch

f+ for the moment.
Firefox has the line:
<!ENTITY rights2.webservices-term1 "&vendorShortName; and its contributors, licensors and partners work to provide the most accurate and up-to-date Services.  However, we cannot guarantee that this information is comprehensive and error-free.  For example, the Safe Browsing Service may not identify some risky sites and may identify some safe sites in error and the Location Aware Service all locations returned by our service providers are estimates only and neither we nor our service providers guarantee the accuracy of the locations provided.">
We probably need something similar. Might be worth comparing the rest of the webservices terms too.

Comment 5

[rsx11m]

The only other item I can find in the Firefox page which we are missing in SeaMonkey seems to be describing the Crash Reporter (may also apply to Telemetry and other phone-home pieces):
<!ENTITY rights.intro-point2.5 "Some features in &brandShortName;, such as the Crash Reporter, give you the option to provide feedback to &vendorShortName;. By choosing to submit feedback, you give &vendorShortName; permission to use the feedback to improve its products, to publish the feedback on its websites, and to distribute the feedback.">

The rest looks sufficiently similar to me, though not identical (less legalese than the FF version).

Comment 6

[rsx11m]

Attachment: Proposed patch (v2)

Includes additions from Comment #4 and Comment #5 with minor changes:

 - I'm referring to both SeaMonkey and Mozilla here, given that some of those
   services (including the Crash Reporter) are coming from their side.

 - I've replaced "products" with "applications" given that SeaMonkey isn't some
   greedy company. ;-)

The remaining entities weren't changed, thus the numbering may be a little odd. I can certainly adjust that, but this means additional work for the localizers.

Comment 7

[rsx11m]

Thanks, pushed as http://hg.mozilla.org/comm-central/rev/79420fdeab5b