Closed Bug 1026058 Opened 11 years ago Closed 11 years ago

[Vertical Homescreen] Edit Mode - Delete icon is jagged and not sharp.

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, feature-b2g:-, b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
blocking-b2g 2.0+
feature-b2g -
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: hnguyen, Assigned: crdlc)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe])

User Story

The delete icon in edit mode are blurry and jagged. The wrong assets may be in use.

Attachments

(4 files)

HS_3Column_BlurredDeleteIcon_06_16.png
178.60 KB, image/png
Details
HS_4Column_BlurredDeleteIcon_06_16.png
161.21 KB, image/png
Details
HS_DeleteIcons.zip
8.11 KB, application/zip
Details
Github pull request
190 bytes, text/html
kgrandon
: review+
Details
No description provided.
User Story: (updated)
Attached file HS_DeleteIcons.zip —
Attaching delete icon for all screen resolutions.
Blocks: vertical-homescreen
Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe][2.0-FL-bug-bash] → ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe]
Blocks: vertical-home-next
No longer blocks: vertical-homescreen
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe][2.0-FL-bug-bash] → ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe] → ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe]
blocking-b2g: --- → 2.0?
feature-b2g: --- → -
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request —
Attachment #8442693 - Flags: review?(kgrandon)
Comment on attachment 8442693 [details] Github pull request Looks good to me, thanks!
Attachment #8442693 - Flags: review?(kgrandon) → review+
Comment on attachment 8442693 [details] Github pull request I think this needs the proper background-size on the remove element first..
Attachment #8442693 - Flags: review+
Attachment #8442693 - Flags: review+
Landed: https://github.com/mozilla-b2g/gaia/commit/b7b67c2768be28c6d8cc4415d83c6c34506e9e70
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Peter, This seems to be minor to the naked eye but for some one with a designer's eye it might be blocking. Please provide your analysis.
Flags: needinfo?(pdolanjski)
Patryk, I need you input here. Blocker?
Flags: needinfo?(pdolanjski) → needinfo?(padamczyk)
Its a question of quality, not normal eye vs designer eye. We should never ship any fuzzy graphics especially on the homescreen. So I would block it, especially since it's an easy, low risk fix.
Flags: needinfo?(padamczyk)
blocking-b2g: 2.0? → 2.0+
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: