1031331 - [homescreen] Do not show the contextmenu while in edit mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1031331.patch

Christian, here is the followup I promised in bug 1028708, with a patch and the according test.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=d0b04fa69a283d24bc052a92190b893c7751d205

Comment 3

[Jacqueline Savory [:jsavory] UX]

From a UX perspective this bug should not be a blocker.

Comment 4

[bhavana bajaj [:bajaj]]

(In reply to jsavory from comment #3)
> From a UX perspective this bug should not be a blocker.

Given this lets consider approval for uplift here once ready and not block on it.

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8447190 [details] [diff] [review]
bug1031331.patch

LGTM although I prefer to do it via events

window.addEventListener('gaiagrid-editmode-start', this);
window.addEventListener('gaiagrid-dragdrop-end', this);

case 'gaiagrid-editmode-start':

  this.container.removeEventListener('contextmenu', this);

case 'gaiagrid-editmode-end':

  this.container.addEventListener('contextmenu', this);

But as I said you can follow this idea or yours, up to you, both of them are good. Although if you implement the code based on events please fix it [1]. The event was named wrongly

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_grid/js/grid_dragdrop.js#L376

Comment 6

[Cristian Rodriguez (:crdlc)]

Sorry window.addEventListener('gaiagrid-dragdrop-end', this); instead of window.addEventListener('gaiagrid-editmode-end', this); I cannot edit my last comment as in github :)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Cristian Rodriguez (:crdlc) from comment #6)
> Sorry window.addEventListener('gaiagrid-dragdrop-end', this); instead of
> window.addEventListener('gaiagrid-editmode-end', this); I cannot edit my
> last comment as in github :)

Yeah, that's one of the thing that is painful on bugzilla (but I really prefer the rest of the review interface).

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/46d39a0cea8c06063ab77ad90770acfba265cbcb

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8447190 [details] [diff] [review]
bug1031331.patch

This is needed for the vertical homescreen.

Comment 10

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/4036ddcee0b7a13e43cf65ab74df6822ed2fc884

Comment 11

[Shally Li（leave from Mozilla）]

Hi Vivien,
    Could you provide the detailed reproduce steps for me to verify this bug?

Thank you!