1041368 - MP4 crypto plain sizes have wrong number of elements

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

DecoderData.plain_sizes has twice as many entries as DecoderData.encrypted_sizes. It should have the same number of entried.

This is because where the plain sizes are stored into the Metadata [1] they're stored with size (smpl->clearsizes.size() * 4), but smpl->clearsizes is a Vector<uint16_t>, so twice as many bytes are stored, and when we copy them in FindData() inside DecoderData::Update() and divide the reported size by 2, we'll get twice the number.

[1] should be  (smpl->clearsizes.size() * 2), not  (smpl->clearsizes.size() * 4).

[1] http://mxr.mozilla.org/mozilla-central/source/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp#3457

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30364f5f934b

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/30364f5f934b