1041384 - Update GMP APIs for decrypt without decoding and reporting capabilities

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I need to update the GMP APIs to support:

* Decrypting buffers without decoding them.
* Signalling to the Gecko parent process whether to use the GMP/CDM in decrypt or decrypt-and-decode mode.
* Remove the "On" prefix in some of my GMP*Callback objects, since the other GMP*Callback objects don't use that convention. This makes the naming convention of the APIs consistent.

My aim is to land the above changes on m-c shortly after the next uplift, i.e. when m-c becomes Fx34.

After the above changes, I'll still need to add an Output Protection interface to GMP API. I'm not sure if that will be in Gecko 34 or Gecko 35.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Update GMP APIs.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8459384 [details] [diff] [review]
Patch

Review of attachment 8459384 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/gmp-api/gmp-decryption.h
@@ +32,5 @@
>  
>    // Size (in bytes) of |IV|.
>    virtual uint32_t IVSize() const = 0;
>  
> +  // Number of enties returned by ClearBytes() and CipherBytes().

entries

::: content/media/gmp/gmp-api/gmp-storage.h
@@ +39,3 @@
>    virtual GMPErr Read() = 0;
>  
> +  // Writes aDataSize bytes of aData into the record, overwritting the

overwriting 
Just proving I'm really reading it....

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3e953be799

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b3e953be799