1048097 - [EME] GMP process leaking nsTArray when in decrypt mode.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Running the GMP/CDM in decrypt mode causes an nsTArray leak:

== BloatView: ALL (cumulative) LEAK STATISTICS, geckomediaplugin process 2532

     |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Rem      Mean       StdDev     Total      Rem      Mean       StdDev
GM   0 TOTAL                                           4      308     1200       77 (   53.19 +/-    23.73)      100        0 (    1.46 +/-     0.66)
PPa  13 nsTArray_base                                   4      308     1178       77 (   54.20 +/-    22.80)        0        0 (    0.00 +/-     0.00)
re
ntnsTraceRefcnt::DumpStatistics: 13 entries

This is the nsTArray in the GMPBufferImpl that's created in GMPDecryptorChild::RecvDecrypt and sent through the GMP for decryption.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8466864 [details] [diff] [review]
Patch

Review of attachment 8466864 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/GMPDecryptorChild.cpp
@@ +156,3 @@
>    auto buffer = static_cast<GMPBufferImpl*>(aBuffer);
>    SendDecrypted(buffer->mId, aResult, buffer->mData);
> +  delete buffer;

Document in the interface .h file that this is an explicit transfer of ownership

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef8d10dc3927

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/58622922646d for build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=45200545&tree=Mozilla-Inbound

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89f0af4d12d4

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/89f0af4d12d4