1049961 - In e10s window, Firefox downloads PDFs that should be displayed with using PDF.js

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Safwan Rahman (:safwan)]

Not working when try to view any pdf from computer by trying to open with Nightly(Firefox). It goes to Download!

Comment 1

[beingalink]

I can't get native pdfjs viewer to display pdfs with e10s enabled. Not sure if this is the same issue. I'm on OS X 10.10.

Comment 2

[Chris Peterson [:cpeterson]]

beingalink, which version of Firefox Nightly are you testing? PDF.js should be fixed for e10s in today's build by bug 942707. PDF.js works for me with e10s in Nightly 35.0a1 build 2014-09-25.

Comment 3

[beingalink]

I'm on 35.0a1 (2014-09-25). The pdfjs viewer works fine in normal mode but in an e10s window pdf links just trigger a download for me. I have no idea why this is.

Comment 4

[Chris Peterson [:cpeterson]]

beingalink, do you have any other add-ons installed? In my default user profile, I have a bunch of add-ons and I can reproduce the problem you reported. But in a clean user profile I use for testing, I have no add-ons and PDF.js displays the PDF in the browser as expected.

Here is a test PDF (about the history of PDF itself :)

http://www.planetpdf.com/planetpdf/pdfs/warnock_camelot.pdf

Comment 5

[beingalink]

Something is profoundly broken for me. I restarted in safe mode and opened an e10s window but now I only get a blank page for everything I try to open with it. I restarted nightly in normal mode and manually disabled all addons but that only resulted in the behavior I already described above (pdfs get downloaded in e10s mode).

Comment 6

[Chris Peterson [:cpeterson]]

Note that e10s is always disabled in safe mode (so people don't get trapped by severe e10s bugs and can't disable it in safe mode).

Like you, I disabled all the add-ons in my default user profile and I can still reproduce the same problem.

Comment 7

[Jim Mathies [:jimm]]

This is working for me. Please make sure you don't have an old pdf.js extension installed first - go to the about:addons page, select any pdf.js extension you might have and click remove. Then restart the browser.

Also check to be sure pdf.js is enabled via prefs - pdfjs.disabled should be false.

If you're still having issues, please post back.

Comment 8

[beingalink]

I had a pdfjs extension for the experimental branch which I had already deleted yesterday to make sure that it's not the cause. I also checked that pdfjs.disabled is set to false. Pdf handling in the application settings is also set to "Preview in Nightly". Still, pdfs are not displayed in an e10s window for me.

Here my about:support output:

Application Basics
------------------

Name: Firefox
Version: 35.0a1
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:35.0) Gecko/20100101 Firefox/35.0
Multiprocess Windows: 1/2

Crash Reports for the Last 3 Days
---------------------------------

All Crash Reports

Extensions
----------

Name: Adblock Plus
Version: 2.6.4
Enabled: true
ID: {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

Name: Adblock Plus Pop-up Addon
Version: 0.9.2
Enabled: true
ID: [e-mail]

Name: DownloadHelper
Version: 4.9.24
Enabled: true
ID: {b9db16a4-6edc-47ec-a1f4-b86292ed211d}

Name: Locko
Version: 1.2
Enabled: true
ID: [e-mail]

Name: ProxTube - Unblock YouTube
Version: 2.0.0.1
Enabled: true
ID: [e-mail]

Name: MEGA
Version: 2.0.190
Enabled: false
ID: [e-mail]

Graphics
--------

Device ID: 0x 863
GPU Accelerated Windows: 2/2 OpenGL (OMTC)
Vendor ID: 0x10de
WebGL Renderer: NVIDIA Corporation -- NVIDIA GeForce 9400M OpenGL Engine
windowLayerManagerRemote: true
AzureCanvasBackend: quartz
AzureContentBackend: quartz
AzureFallbackCanvasBackend: none
AzureSkiaAccelerated: 0

Important Modified Preferences
------------------------------

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.cache.frecency_experiment: 2
browser.places.smartBookmarksVersion: 7
browser.sessionstore.upgradeBackup.latestBuildID: 20140925030203
browser.startup.homepage_override.buildID: 20140925030203
browser.startup.homepage_override.mstone: 35.0a1
dom.mozApps.used: true
extensions.lastAppVersion: 35.0a1
font.internaluseonly.changed: false
media.gmp-gmpopenh264.lastUpdate: 1405785829
media.gmp-gmpopenh264.path: /Users/Tobias/Library/Application Support/Firefox/Profiles/cvmagti9.default/gmp-gmpopenh264
media.gmp-gmpopenh264.version: 1.0
media.gmp-manager.lastCheck: 1411685901
network.cookie.prefsMigrated: true
places.database.lastMaintenance: 1411661716
places.history.expiration.transient_current_max_pages: 100664
plugin.disable_full_page_plugin_for_types: application/pdf
plugin.importedState: true
plugin.state.flash: 1
plugins.notifyMissingFlash: false
print.print_bgcolor: false
print.print_bgimages: false
print.print_colorspace:
print.print_command:
print.print_downloadfonts: false
print.print_duplex: 1515870810
print.print_evenpages: true
print.print_in_color: true
print.print_margin_bottom: 0.5
print.print_margin_left: 0.5
print.print_margin_right: 0.5
print.print_margin_top: 0.5
print.print_oddpages: true
print.print_orientation: 0
print.print_page_delay: 50
print.print_paper_data: 0
print.print_paper_height: 11.00
print.print_paper_name:
print.print_paper_size_type: 1
print.print_paper_size_unit: 0
print.print_paper_width: 8.50
print.print_plex_name:
print.print_resolution: 1515870810
print.print_resolution_name:
print.print_reversed: false
print.print_scaling: 1.00
print.print_shrink_to_fit: true
print.print_to_file: false
print.print_unwriteable_margin_bottom: 57
print.print_unwriteable_margin_left: 25
print.print_unwriteable_margin_right: 25
print.print_unwriteable_margin_top: 25
privacy.sanitize.migrateFx3Prefs: true
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1410989386

Important Locked Preferences
----------------------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.10.7
Version in use: 4.10.7

NSS
Expected minimum version: 3.17.1 Basic ECC
Version in use: 3.17.1 Basic ECC

NSSSMIME
Expected minimum version: 3.17.1 Basic ECC
Version in use: 3.17.1 Basic ECC

NSSSSL
Expected minimum version: 3.17.1 Basic ECC
Version in use: 3.17.1 Basic ECC

NSSUTIL
Expected minimum version: 3.17.1
Version in use: 3.17.1

Experimental Features
---------------------

Comment 9

[beingalink]

Some status update: I just tried with yesterdays respin and enabled e10s globally in the preferences (restarted firefox). Now pdfs open just fine in the browser using pdfjs.
I then disabled e10s globally, restarted firefox and opened an e10s window. As before, pdfs get downloaded instead of displayed in the browser window.
It seems like there is some difference between having e10s globally enabled and using a separate e10s window with e10s globally disabled.

Comment 10

[Jim Mathies [:jimm]]

(In reply to beingalink from comment #9)
> Some status update: I just tried with yesterdays respin and enabled e10s
> globally in the preferences (restarted firefox). Now pdfs open just fine in
> the browser using pdfjs.
> I then disabled e10s globally, restarted firefox and opened an e10s window.
> As before, pdfs get downloaded instead of displayed in the browser window.
> It seems like there is some difference between having e10s globally enabled
> and using a separate e10s window with e10s globally disabled.

ah, known issue, but we're not too worried about it. The e10s window in this case doesn't get pdf.js frame script loaded.

http://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#671

aWindow.messageManager.loadFrameScript("resource://pdf.js/pdfjschildbootstrap.js", true);

I think the fix here is to move this init code back to browser.js and call it for every new window.

[e-mail], would you like to take a shot at writing a patch for this?

Comment 11

[beingalink]

(In reply to Jim Mathies [:jimm] from comment #10)
> [e-mail], would you like to take a shot at writing a patch
> for this?

That would be quite over my head, I'm sorry. :) I'll start using nightly with e10s globally prefed on soon anyway. Only few annoying bugs left. So this issue doesn't bother me too much.

Comment 12

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I confirmed this bug is reproducible on the Firefox's latest nightly build + pdf.js which is built-in Firefox.

[environment]
* nightly based revision: https://hg.mozilla.org/mozilla-central/rev/80e18ff7c7b2
* pdf.js: 1.0.907

[step to reproduce]
Open pdf file in e10s mode window. If you open ~.pdf file directly in a tab, or open a web page which embed a pdf file that are expected to display as inlined item, either will cause a same results.

[Result]
* pdf files are not rendered in Firefox.
* Firefox downloads a pdf file as a normally downloaded file.
* In private browsing e10s window, this file download is recorded to browser's history as downloaded files in normal window.

[expected]
* Even if we try to open a pdf files, Firefox should render it as opening it in non-e10s window.

Comment 13

[Erin Lancaster [:elan]]

SV can you please double check this?