1056841 - ###!!! ASSERTION: These should always be in sync!: 'slowNode == node'

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gabor Krizsanits (INACTIVE)]

Attachment: Always nulling mContainingShadow in Element::UnbindFromTree

In Bug 777674 we hit this assertion. More info: https://bugzilla.mozilla.org/show_bug.cgi?id=777674#c91

We got an nsXULElement with nulled parent but the mContainingShadow were not nulled out, I think the problem is that we null that out in the #ifdef MOZ_XUL case if the xulElem is not null. I think that's a bug, and we always should...

Comment 1

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8476691 [details] [diff] [review]
Always nulling mContainingShadow in Element::UnbindFromTree

I didn't put much effort to figure out a nicer version, wanted to know first if you think this is a right fix or I'm doing something stupid...

Comment 2

[William Chen [:wchen]]

Comment on attachment 8476691 [details] [diff] [review]
Always nulling mContainingShadow in Element::UnbindFromTree

You're right, we should be nulling mContainingShadow regardless of whether the element is XUL.

Comment 3

[Gabor Krizsanits (INACTIVE)]

https://tbpl.mozilla.org/?tree=Try&rev=d78452ef953b

Comment 4

[Gabor Krizsanits (INACTIVE)]

Attachment: Always nulling mContainingShadow in Element::UnbindFromTree. v1

Comment 5

[William Chen [:wchen]]

Comment on attachment 8479692 [details] [diff] [review]
Always nulling mContainingShadow in Element::UnbindFromTree. v1

Review of attachment 8479692 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/Element.cpp
@@ +1488,5 @@
>    }
>  
>    // Unset this since that's what the old code effectively did.
>    UnsetFlags(NODE_FORCE_XBL_BINDINGS);
> +  bool resetBindingParent = true;

Let's call this clearBindingParent

@@ +1500,3 @@
>  #endif
> +
> +  if (nsDOMSlots* slots = GetExistingDOMSlots()) {

Assignment should go on its own line.

Comment 6

[Gabor Krizsanits (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b215da11652

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b215da11652