1058399 - VideoData leak with mac fmp4

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Recent try pushes show we're leaking VideoData on shutdown. I've seen this locally as well.

21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 AsyncTransactionTrackersHolder (72 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 100 CompositableClient (4000 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 CondVar (40 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 194 GfxTextureWasteTracker (776 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 144 Image (13824 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 194 MemoryTextureClient (26384 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 Mutex (32 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 PImageBridgeChild (760 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 RefCountedMonitor (80 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 2 RefCountedTask (32 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 144 SharedPlanarYCbCrImage (35712 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 144 VideoData (11520 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 WeakReference<MessageListener> (16 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 ipc::MessageChannel (536 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 3 nsTArray_base (24 bytes)
21:12:37  WARNING -  TEST-UNEXPECTED-FAIL | leakcheck | 93808 bytes leaked (AsyncTransactionTrackersHolder, CompositableClient, CondVar, GfxTextureWasteTracker, Image, ...)

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

In AppleVTDecoder::Flush() you call mReorderQueue.Clear(), but that won't delete the VideoData objects in the queue, you need to pop and delete them until the queue is empty. At least, that's my guess.

Comment 2

[Ralph Giles (:rillian)]

Attachment: Call delete when clearing mReorderQueue.

Looks like it. Thanks!

Comment 3

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ad9756bb025

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ad9756bb025