1061118 - Opening an AttentionWindow while the keyboard is showing causes appWindow sizing issues

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Etienne Segonzac (:etienne)]

STR:
- open the dialer
- go to the contact tab
- tap the new contact button
- one field is focused and the keyboard is displayed

- get a phone call

Result:
- the keyboard leaves half of the screen black
- the dialer appwindow and attention window are only half as high as they should

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23569

The second time opening of an attention window will do resize before requestopen being dispatched to keyboardManager so we need another event to dismiss it.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

BTW I also fixed: when attention window is closed, the bottom active app window should be resized according to keyboard.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/7e469783859785a8bd4bf02a802f32561c84be7b

Comment 4

[Etienne Segonzac (:etienne)]

I think we missed the 2.1 branch for this one, Alive can you request approval for the patch?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

[Blocking Requested - why for this release]:

This is a regression of a v2.1 feature I think we could ask 2.1?

The bug will make the user hard to cooperate with callscreen because it was incorrectly resized.

Comment 6

[howie [:howie]]

Triage: feature regression, blocking.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8482215 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23569

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
regression from bug 927862
[User impact] if declined:
user will see half of callscreen/alarm when they come while keyboard is on
[Testing completed]:
yes
[Risk to taking this patch] (and alternatives if risky):
no
[String changes made]:
no

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/3e85cbf6348096bc855153f148c90a2934de0d60

Comment 9

[[:RJ]]

This issue is verified fixed in Flame 2.2 Master KK (319mb) (Full Flash) Flame 2.1 KK (319mb) (Full Flash)

when the keyboard is open in the create a contact menu from the dialler app, and user receives a call, the keyboard is dismissed as it should with no sizing issues and before the screen is completely over the screen the keyboard is removed with no black box

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0