1065144 - Unhide Loop FxA UI

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Matthew N. [:MattN]]

Some UI (e.g. sign in link and gear menu) are hidden with display: none until the implementation "works". This bug is to track unhiding it when the client and server are ready. The patch should be minimal.

Comment 1

[Matthew N. [:MattN]]

When will the server changes from bug 1047667 make it to production so QA can start testing and we can unhide the UI for Nightly users (who point to https://loop.services.mozilla.com)?

Comment 2

[Matthew N. [:MattN]]

FWIW, Firefox will be ready tomorrow.

Comment 3

[Matthew N. [:MattN]]

Attachment: v.1 Unhide link and gear, make Account option work, and update link visibility

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8491903 [details] [diff] [review]
v.1 Unhide link and gear, make Account option work, and update link visibility

Review of attachment 8491903 [details] [diff] [review]:
-----------------------------------------------------------------

It would be good to get some tests for this, to make sure that we display the account settings.

I can't actually test it at the moment, as for some reason, the FxA server isn't letting me log in, so f+ for now.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8491903 [details] [diff] [review]
v.1 Unhide link and gear, make Account option work, and update link visibility

Review of attachment 8491903 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, I've now been able to test this, and it looks good. I'm slightly pondering if selecting the Account option, shouldn't close the panel as well, but we could always spin that to another bug and ask for UX opinion.

As I mentioned before, it'd be nice to get a test to make sure the account settings are displayed correctly, but given what testing & other patches this benefits, I'm happy for this to land without if you want to land it earlier rather than later.

Comment 6

[Matthew N. [:MattN]]

(In reply to Mark Banner (:standard8) from comment #4)
> It would be good to get some tests for this, to make sure that we display
> the account settings.

I think these tests already cover that: https://mxr.mozilla.org/mozilla-central/source/browser/components/loop/test/desktop-local/panel_test.js?rev=9b4a0e65bfaa#182

Unless you mean opening the tab?

Comment 7

[Matthew N. [:MattN]]

I created a Try build with this patch (and all of the dependencies): https://tbpl.mozilla.org/?tree=Try&rev=7ad41e6ea20e

Services and Desktop QA can use it to verify functionality against https://loop-dev.stage.mozaws.net (for the pref loop.server).  Known issues for Loop FxA: https://mnoorenberghe.github.io/bz-dependency-buglist/?list=979845&product=Loop&flags=1

I'm waiting to land this patch in the tree until the production server has the necessary changes.

Comment 8

[Matthew N. [:MattN]]

Try push build directory: https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7ad41e6ea20e/

Comment 9

[u279076]

Edwin, can you please make sure the Try build gets the appropriate Services testing?

Paul, since you'll be available several hours before I on Monday, can you please do some exploratory testing of the UI/UX using the Try build?

Comment 10

[u279076]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> Edwin, can you please make sure the Try build gets the appropriate Services
> testing?
> 
> Paul, since you'll be available several hours before I on Monday, can you
> please do some exploratory testing of the UI/UX using the Try build?

Sorry, needinfo flags didn't get set properly.

Comment 11

[Mark Banner (:standard8)]

(In reply to Matthew N. [:MattN] from comment #6)
> (In reply to Mark Banner (:standard8) from comment #4)
> > It would be good to get some tests for this, to make sure that we display
> > the account settings.
> 
> I think these tests already cover that:
> https://mxr.mozilla.org/mozilla-central/source/browser/components/loop/test/
> desktop-local/panel_test.js?rev=9b4a0e65bfaa#182
> 
> Unless you mean opening the tab?

Aha! I was thinking about opening the tab (via mochitest?), but I'd settle for an additional test there along the lines of:

it("should open the FxA settings when the account entry is clicked"

with a check for navigator.mozLoop.openFxASettings being called

Comment 12

[Matthew N. [:MattN]]

Attachment: v.2 with test

The server has been deployed to prod in bug 1070246 and I confirmed that it works for me so I will land this today upon review.

(In reply to Mark Banner (:standard8) from comment #11)
> (In reply to Matthew N. [:MattN] from comment #6)
> > Unless you mean opening the tab?
> 
> Aha! I was thinking about opening the tab (via mochitest?), but I'd settle
> for an additional test there along the lines of:
> 
> it("should open the FxA settings when the account entry is clicked"
> 
> with a check for navigator.mozLoop.openFxASettings being called

Done

Comment 13

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/70aaf98d3bb0

Comment 14

[Edwin Wong [:edwong]]

offloading to :pdehaan

Comment 15

[Paul Silaghi, QA [:pauly]]

(In reply to Matthew N. [:MattN] from comment #7)
> Known issues for Loop FxA:
> https://mnoorenberghe.github.io/bz-dependency-buglist/
> ?list=979845&product=Loop&flags=1
No issues here. Matt, could you please take a look?

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/70aaf98d3bb0

Comment 17

[Matthew N. [:MattN]]

(In reply to Paul Silaghi, QA [:pauly] from comment #15)
> (In reply to Matthew N. [:MattN] from comment #7)
> > Known issues for Loop FxA:
> > https://mnoorenberghe.github.io/bz-dependency-buglist/
> > ?list=979845&product=Loop&flags=1
> No issues here. Matt, could you please take a look?

Oh, you need to load this page in Firefox for it to work.

Btw. I'm going to change bugs that were marked qe-verify- due to the UI being hidden to qe-verify+ now. This should be unhidden in tomorrow's Nightly.

Comment 18

[Paul Silaghi, QA [:pauly]]

The Loop FxA UI is no longer hidden.
Verified fixed 35.0a1 (2014-09-25) Win 7, OS X 10.9.5, Ubuntu 13.04.
Filed bug 1072965 as a follow up issue.

Comment 19

[u279076]

Paul can you please test this again across platforms using the following Try-server build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f9eb2cbac352

Comment 20

[Paul Silaghi, QA [:pauly]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #19)
> Paul can you please test this again across platforms using the following
> Try-server build?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-
> f9eb2cbac352
Verified fixed Win 7, OS X 10.9.5, Ubuntu 13.04.

Comment 21

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8493311 [details] [diff] [review]
v.2 with test

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 22

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa8599460f1d

Comment 23

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8493311 [details] [diff] [review]
v.2 with test

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.

Comment 24

[Mark Banner (:standard8)]

The NI was for testing purposes before landing (comment 10/comment 14), however, this is now resolved & verified, hence clearing the NI flag.