1071464 - Object.isFrozen() should return true when given primitive values as input

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[ziyunfei]

js> Object.isFrozen("foo")
TypeError: "foo" is not an object
// should return true in ES6

Comment 1

[ziyunfei]

Attachment: bug-1071464.patch

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8493590 [details] [diff] [review]
bug-1071464.patch

Review of attachment 8493590 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!

Did you run all tests and make sure that no existing tests break for this? I'd be surprised if we didn't have tests covering the old behavior.

Do you have level 1 commit access? If so, please do a try run testing just one platform (Linux64 is usually good) with debug-only and including all test suites except Talos. Once that turns up green, you can paste the test run's URL in the bug and set checkin-needed and a sheriff will land the patch for you.

If you don't yet have level 1 commit access, you should apply for it using this as a guide: https://www.mozilla.org/hacking/commit-access-policy/ CC me on the bug and I'll vouch for you. Also let me know here, and I'll do a try run as described above.

Comment 3

[ziyunfei]

https://tbpl.mozilla.org/?tree=Try&rev=17c07b1225ae

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f042830253e2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f042830253e2