1071775 - [Dialer] choppy animation when receiving and ending calls in landscape mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Seth Miko [:SMiko]]

Attachment: landscape.txt

Description: When receiving a call in landscape mode, the dialer is briefly displayed in landscape mode then moves to portrait mode. The animation is choppy when this occurs. 

Repro Steps:
1: Update a Flame to 20140923003005
2: Open a game or website and put the phone in landscape orientation.
3: Place a call to the DUT from another device.

Actual:
The animation of dialer launching is choppy.

Expected:
The animation is smooth

Flame 2.1(KK base/319mb)

Environmental Variables:
Device: Flame 2.1 (319mb)
Build ID: 20140923003005
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 
Firmware Version: 
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
This issue also occurs when ending a call in landscape mode.

Repro frequency: 100%

See attached: logcat 

Video clip: http://youtu.be/nVryes4u1lE

Comment 1

[Seth Miko [:SMiko]]

This issue DOES occur on Flame 2.2 (KK base/319mb), Flame 2.2 (JB base/319mb), Open C 2.2, Flame 2.1 (KK base/512mb), Flame 2.1 (JB base/319mb), and Open C 2.1

Actual result: Choppy animation.

Flame 2.2 KitKat Base (319mb)

Environmental Variables:
Device:  Flame 2.2 Master
BuildID: 20140923073003
Gaia: 37b8a812c642ca616bf9457cb9b71e45261cdfa8
Gecko: 9e193395b912
Version: 35.0a1 (2.2)
Firmware: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.2 Jelly Bean Base (319mb)

Enviromental Variables:
Device: Flame 2.2 Master
BuildID: 20140923040203
Gaia: 3c898380b47f298cd3b7a0dacb3a6529e94322d4
Gecko: 790f41c631cc
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

2.2 Open C

Environmental Variables:
Device: Open_C Master
Build ID: 20140923040203
Gaia: 3c898380b47f298cd3b7a0dacb3a6529e94322d4
Gecko: 790f41c631cc
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KitKat Base (512mb)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140923003005
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.1 Jelly Bean Base (319mb)

Enviromental Variables:
Device: Flame 2.1
BuildID: 20140923000204
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

2.1 Open C

Environmental Variables:
Device: Open_C 2.1
Build ID: 20140923000204
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

This issue does NOT occur on Flame 2.0 (KK base/319mb), Flame 2.0 (JB base/319mb), or Open C 2.0

Actual result: Smooth animation.

Flame 2.0 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140923063014
Gaia: 6449cc35a8f0704d95acac374ba857bde4b86d6c
Gecko: b930730dba81
Version: 32.0 (2.0)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.0 Jelly Bean Base (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140923000205
Gaia: 8d7f2ac85f3154bdb149d67e5c2f9b035f5e4105
Gecko: 6dd19beda1c2
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Environmental Variables:
Device: Open_C 2.0
BuildID: 20140923000205
Gaia: 8d7f2ac85f3154bdb149d67e5c2f9b035f5e4105
Gecko: 6dd19beda1c2
Version: 32.0 (2.0)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Anthony Ricaud (:rik)]

I'm guessing this is affected by bug 927862

Comment 3

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:
Nominating this as a blocker because the animation is very slow and looks bad. Also this is a regression

Comment 4

[Joshua Mitchell (Inactive)]

removing regression-window tag based on 2 things: Comment 2 already indicates what is suspected to have cause this and getting a window for a perf issue is very difficult - there needs to be an easily identifiable "working" state and "broken" state and here we are dealing with varying degrees of choppyness.

Comment 5

[howie [:howie]]

Triage: regression, blocking.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Could you steal if from me? The solution is simple: Add className is attentionWindow/callscreenWindow in appTransitionController closing handler before setOrientation call.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,
thanks for advise, please check my patch. Thanks.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8499400 [details] [review]
PR to master

r+ with nit, thanks

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/3d7c3b9155aead5fb214c80e96d2ded3d85441c1

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): according to comment 2, it's due to bug 927862
[User impact] if declined: http://youtu.be/nVryes4u1lE , The animation of dialer launching is choppy.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/7cc3d25becf7dbb88269b99c6c68f05f83b4a384

Comment 12

[John Thomas [:Johnt]]

This issue does NOT occur on the Flame 2.2 Master (319mb) and the Flame 2.1 KK (319mb)

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Receiving call while in an intensive app does not appear choppy.