1081251 - EME mochitests can pass even if the plugin crashes (e.g., ASAN)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

It is possible for the mochitest content/media/test/test_encryptedMediaExtensions.html to pass even if the EME plugin container crashes while processing the test data.

This is more of a problem on ASAN builds, because they disable the crash reporter, and the test harness doesn't know that it's possible for a crash to happen without a minidump (this is now bug 1081229), but it seems worthwhile to make the test stricter independently of that.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

JW: Can you take this too? It follows on from bug 1082203. You'll need to detect crashes and fail the test in the test_eme* tests.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Btw, I can't find the file test_encryptedMediaExtensions.html anymore...

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

test_eme_playback.html is pretty much the same as test_encryptedMediaExtensions.html...

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

I think all we need to do here is go through the EME mochitests and ensure that every <video> or <audio> element using EME has an "error" event handler on it.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

We can have SetupEME() return a video element with 'error' handler registered by default so new test cases will not forget to register one.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to JW Wang [:jwwang] from comment #5)
> We can have SetupEME() return a video element with 'error' handler
> registered by default so new test cases will not forget to register one.

Sounds good.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1081251_register_error_handler-v1.patch

register error handlers for all media elements in EME mochitests.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

try: https://tbpl.mozilla.org/?tree=Try&rev=0051ed934b53

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c645dd3b5468

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c645dd3b5468

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/00ac75ab182f

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572326 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572326 [details] [diff] [review]
Beta patch

Previously approved as part of the EME platform landing on Beta.