1082239 - test_encryptedMediaExtensions.html | gizmo-frag-cencinit.mp4-1 Failed to set MediaKeys on <video> element

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/250146966b12

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Oops, forgot to [leave open]. Still need to fix it properly.

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Make MediaSourceResource::GetPrincipal return MediaSource script principal

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Make MediaSourceResource::GetPrincipal return MediaSource script principal

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Make MediaSourceResource::GetPrincipal return MediaSource script principal

argh.

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8505161 [details] [diff] [review]
Make MediaSourceResource::GetPrincipal return MediaSource script principal

Review of attachment 8505161 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceResource.h
@@ +53,5 @@
>    virtual nsresult Open(nsIStreamListener** aStreamListener) MOZ_OVERRIDE { UNIMPLEMENTED(); return NS_ERROR_FAILURE; }
>  
> +  virtual already_AddRefed<nsIPrincipal> GetCurrentPrincipal() MOZ_OVERRIDE
> +  {
> +    nsRefPtr<nsIPrincipal> ret = mPrincipal;

s/ret/principal/

or

return nsRefPtr<nsIPrincipal>(mPrincipal).forget();

Comment 7

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f520729fb38

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f520729fb38

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.