1100164 - [EME] ClearKey CDM is not accessible in Nightly builds

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

For some reason, the ClearKey GMP is usable in locally built Firefox builds, but it's not usable in officially packaged Nightly builds.

STR:
1. Update Nightly, disable e10s, set media.eme.enabled=true
2. Load http://people.mozilla.org/~cpearce/eme/sanity.html

Observed result, logging:
  !MediaKeys.isTypeSupported(org.w3.clearkey)
  Failed to create MediaKeys

Expected logging:
  Created MediaKeys

ClearKey GMP is loaded as expected in local m-c builds.

If I set MOZ_GMP_PATH to the gmp-clearkey install dir (C:\Program Files (x86)\Nightly\gmp-clearkey\0.1) I get the expected result.

Nightly 32bit, 36.0a1 (2014-11-16), Win8.1 x64.

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Will be fixed in bug 1100450.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: bug1100164.patch

Comment 3

[Stephen A Pohl [:spohl]]

Comment on attachment 8525054 [details] [diff] [review]
bug1100164.patch

Review of attachment 8525054 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/internal/OpenH264Provider.jsm
@@ +276,5 @@
>      if (this.gmpPath && enabled) {
>        this._log.info("startup() - adding gmp directory " + this.gmpPath);
>        try {
> +        let greBinDir = Services.dirsvc.get(NS_GRE_BIN_DIR, Ci.nsILocalFile);
> +        gmpService.addPluginDirectory(OS.Path.join(greBinDir.path,

Copy/paste error? I think this was meant to go about 8 lines further down.

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: bug1100164.patch

Yeah, cherry pick fail. Apologies for the r?spam.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Thanks for reviewing the patch during your conference Blair!

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d895a54de81

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d895a54de81

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.