1109389 - Assertions in MediaTaskQueue when shutting down EMEDecryptor in mochitest

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

When running mochitests dom/media/test/test_eme* I get assertion failures:

[4380] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file c:\Users\cpearce\src\mozilla\purple\dom\media\MediaTaskQueue.cpp, line 106
[4380] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file c:\Users\cpearce\src\mozilla\purple\dom\media\MediaTaskQueue.cpp, line 106

This is because the EME PDM creates a task queue which is shares with the EMEDecryptors that it creates. So if an EME PDM creates two EMEDecryptors (say one for the video and another for the audio streams...) when the first EMEDecryptor shutsdown, it will shutdown the task queue, and the second EMEDecryptor won't be able to use it to shutdown. The failure to use the task queue is why we see those assertion failures.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Don't share task queues with all EMEDecryptors the EME PDM creates.

Have the constructor of EMEDecryptor create its own task queue.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ea53cf992be6
https://tbpl.mozilla.org/?tree=Try&rev=ea53cf992be6

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=16dacd65d641
https://tbpl.mozilla.org/?tree=Try&rev=16dacd65d641

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Because life was too easy before WAE was turned on:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6bbcc2e5289a

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Store GMP record name in record file on disk

Fixed WAE productivity suck.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6bbcc2e5289a

Carry forward r=kinetik.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfcd18d91159

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dfcd18d91159

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8534127 [details] [diff] [review]
Patch: Store GMP record name in record file on disk

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: less consistent testing, sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: I've not been backporting EME-related changes, so this may end up requiring other related fixes. However, EME itself is still pref'd-off in Aurora, and this is an isolated change, so I'd say the risk is low.
[String/UUID change made/needed]: none.

The MSE-related patches in bug 1110534 depend on this change.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/66f56347d6c7

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.