1111101 - delete (((foo))) should be an early error

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

See 12.5.4.1 Early Errors for the delete operator.

Comment 1

[Jeff Walden [:Waldo]]

Fixed by bug 1084959, which made parenthesization of any node be a no-op, *unless* that node was a string literal (this being necessary to distinguish "use strict" from its ineffective parenthesized cousin).  While the idea of that fix was definitely right, and it fixed the problem it intended to fix, it was incomplete: a whole bunch more things need to have non-identity transformation under setInParens.  Bug 1122286 will fix those cases shortly.

I have a test for this which I'll upload here, then land next time I'm landing patches in the tree.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Test

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Test, with a few more tweaks

Comment 4

[Jeff Walden [:Waldo]]

Landed the test: https://hg.mozilla.org/integration/mozilla-inbound/rev/dcbfef090900

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dcbfef090900