1114011 - for autocomplete with for minresultsforpopup > 1: entering match doesn't work properly

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: bugXXX_minresultsforpopup_gt_1.patch

+++ This bug was initially created as a clone of Bug #1043310 +++

For an autocomplete widget with for minresultsforpopup > 1, entering match doesn't work properly in all cases (like the test included in the patch). Thunderbird uses minresultsforpopup=2 so the result is shown inline if there is only one match.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8539681 [details] [diff] [review]
bugXXX_minresultsforpopup_gt_1.patch

Review of attachment 8539681 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/autocomplete/nsAutoCompleteController.cpp
@@ +486,5 @@
>      input->GetPopupOpen(&isOpen);
> +    // In case minresultsforpopup > 1 the popup is not "open" but the
> +    // search suggestion is showing inline, so if mRowCount > 0 we should
> +    // treat that as open too.
> +    if (isOpen || mRowCount > 0) {

I'd prefer to restrict this a little bit, I don't trust our mRowCount management enough:

// If minresultsforpopup > 1 and there's less matches than the minimum
// required, the popup is not open, but the search suggestion is showing
// inline, so we should proceed as if we had the popup.
uint32_t minResults;
input->GetMinResultsForPopup(&minResults);
if (isOpen ||
    (mRowCount > 0 && mRowCount < minResultsForPopup)) {

::: toolkit/content/tests/chrome/test_autocomplete4.xul
@@ +158,5 @@
>      completeFromMiddle: true, 
>      result: "Result",
>      start: 6, end: 6
>    },
> +  { 

trailing space

@@ +192,5 @@
>  }
>  
>  function runCurrentTest() {
>    var autocomplete = $("autocomplete");
> +  if (currentTest.minResultsForPopup != undefined)

if ("minResultsForPopup" in currentTest)

Comment 2

[Magnus Melin [:mkmelin]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b189101e92c5
https://hg.mozilla.org/integration/mozilla-inbound/rev/305c554e7994

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/305c554e7994