1116384 - attached MediaSources should keep their media element alive

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Karl Tomlinson (:karlt)]

SourceBuffer.appendBuffer() can require its MediaSource's attached media
element to queue progress and/or durationchange events, and so the
media element needs to live long enough to do this.  Similarly MediaSource.endOfStream() can generate suspend and/or durationchange events.

This is currently not a direct problem due to bug 1114885 and the media element always NETWORK_LOADING even though it should be NETWORK_IDLE after
MediaSource.endOfStream() is called (at least) if no frames have been evicted.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: keep media element alive from attached MediaSource r?

Comment 2

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef5666f6f49e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef5666f6f49e

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8542414 [details] [diff] [review]
keep media element alive from attached MediaSource r?

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. This does affect non-MSE code, but it straightforward.
[String/UUID change made/needed]: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c1d21f6b75bf