1120503 - Fix seal/freeze for typed arrays

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

>              // Typed arrays are always sealed.
>              *resultp = true;
>          } else {
>              // Typed arrays cannot be frozen, but an empty typed array is
>              // trivially frozen.

Jeff pointed out that neither comment is true anymore (bug 1112778 comment 22).

Comment 1

[Tom S. (please needinfo tschuster)]

In theory we just need to remove the if (IsAnyTypedArray(obj)) block and add some tests.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: v1 - Verify sealed/frozen status correctly for typed arrays

As I suggested, this just removes the special code for typed arrays. I added some tests that makes sure we still consider non-extensible empty arrays as sealed and frozen. And some other cases like that non-empty arrays are never frozen, because the elements always stay writable.

Comment 4

[Tom S. (please needinfo tschuster)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f68cea9b4c9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f68cea9b4c9