Closed Bug 1122072 Opened 11 years ago Closed 10 years ago

Close tabs tray when last normal tab is closed

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected, firefox43 affected, firefox44 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox42 --- affected
firefox43 --- affected
firefox44 --- verified

People

(Reporter: mhaigh, Assigned: tynn, Mentored)

References

Details

(Whiteboard: [lang=java])

Attachments

(1 file)

bug1122072.patch
2.17 KB, patch
mhaigh
: review+
Details | Diff | Splinter Review
On tablet, when the last tab in the normal tabs tray is closed, the title of the tab switches from "about:home" to "Fennec Home". The expected behaviour should be that the tab tray closes if you try to close the last normal tab.
Summary: Fix issue where closing the last tab in the normal tabs tray causes title to quickly change → [tablet] Close tabs tray when last normal tab is closed
I was going to file this bug about the new tabs tray behavior on phones, but I see it's already filed about tablets! I think this fact that this regresses the old phone tabs tray behavior makes this a higher priority.
Blocks: tabs-tray
Summary: [tablet] Close tabs tray when last normal tab is closed → Close tabs tray when last normal tab is closed
Attached patch bug1122072.patch — — Splinter Review
Closing tabs tray when last tab is being closed. The first part of the patch ensures that the tray doesn't add tabs while it's being closed.
Attachment #8667273 - Flags: review?(mhaigh)
Comment on attachment 8667273 [details] [diff] [review] bug1122072.patch Review of attachment 8667273 [details] [diff] [review]: ----------------------------------------------------------------- Looks great. Let's get this landed!
Attachment #8667273 - Flags: review?(mhaigh) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9629c91c939b
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Tested with: Device: Samsung Galaxy Note 5 (Android 5.1.1) Build: Firefox for Android 44.0a1 (2015-10-04) Go to normal browsing and open 2 tabs: gmail.com and facebook.com. Open tab tray and close them. Tab tray is closed and about:home is displayed. Also, go to private browsing and open 2 tabs. Open tab tray and close them. Tab tray will be closed after closing the last tab and normal browsing with about:home is displayed. Is this expected?
Thanks Christian! If you're interested in more, perhaps bug 1172083?
Yes this is expected. This bug was marked resolved correctly I believe.
Flags: needinfo?(alam)
Based on comment 8 I will mark status-firefox44 verified
status-firefox44: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: