1125628 - Implement parts of [[DefineOwnProperty]] for typed arrays

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S. (please needinfo tschuster)]

Attachment: define-property-on-typed-array

We still don't handle indexes completely, but it's a step in the right direction. Sadly NativeDefineProperty totally goes behind our back right now.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: v2 - implement [[DefineOwnProperty]]

I forgot to change DefineProperties and didn't include my test.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8554300 [details] [diff] [review]
v2 - implement [[DefineOwnProperty]]

Review of attachment 8554300 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_6/TypedArray/object-defineproperty.js
@@ +1,2 @@
> +var obj = new Int32Array(2);
> +obj[0] = 100;

Good test, but.  Modify a few of these (successful) definitions by biasing them by 2**32 in either direction.  And add a few tests along these lines with Uint8ClampedArray, that check that negative values clamp to 0 and that values >= 255 clamp to 255.

Comment 3

[Tom S. (please needinfo tschuster)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b35d3104b6bd

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b35d3104b6bd