1127379 - Make TabParent::GetWidgetNativeData less failure prone

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jim Mathies [:jimm]]

#3 top KillHard cause (see parent bug)

mozilla::dom::PBrowserChild::SendGetWidgetNativeData(unsigned int *)

http://mxr.mozilla.org/mozilla-central/source/dom/ipc/TabParent.cpp#2118

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

I see no reason why a failure in GetNativeData should abort the content process. The code on the receiving end of theses calls should deal with unexpected failures here gracefully. If not, that's a new bug.

http://mxr.mozilla.org/mozilla-central/ident?i=GetNativeData

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

RecvGetWidgetNativeData should init aValue too.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8556756 [details] [diff] [review]
patch

Review of attachment 8556756 [details] [diff] [review]:
-----------------------------------------------------------------

Have you checked the callsites to see if they can really handle this?

What causes us to fail to return native data anyway?

Comment 4

[Jim Mathies [:jimm]]

> Have you checked the callsites to see if they can really handle this?

We make two calls, both for window handles - 
http://mxr.mozilla.org/mozilla-central/ident?i=SendGetWidgetNativeData

> What causes us to fail to return native data anyway?

Good question, we don't know yet. This bug is part of that investigation.

Note we're also looking at improving KillHard feedback in bug 1124933.

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44609e3fb797

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/44609e3fb797