Closed
Bug 1128076
Opened 11 years ago
Closed 11 years ago
Clean up naming around unboxed value MIR accesses
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
69.95 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
After bug 1116855, MLoadTypedArrayElement will be used for typed arrays, typed object, and unboxed objects. The alias set flag TypedArrayElement is also used for each of these locations. This op, its LIR version, and other multi-use opcodes should be renamed and cleaned up to better indicate their generic nature.
|
Assignee | |
Comment 1•11 years ago
|
||
Rename {Load,Store}TypedArrayElement to {Load,Store}UnboxedScalar, along with a few other classes and terms that are used for accesses on objects other than typed arrays. This also removes some dead PJS code. FWIW the SetElem_Unsafe stuff seems to also be dead except for a single access in the Array.map self hosted code.
Assignee: nobody → bhackett1024
Attachment #8574379 -
Flags: review?(jdemooij)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8574379 [details] [diff] [review]
patch
Review of attachment 8574379 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8574379 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•