1130685 - Implement Service Worker Clients.matchAll ClientQueryOptions options

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

The Clients.getAll() method was renamed to matchAll():

  https://github.com/slightlyoff/ServiceWorker/issues/610
  https://github.com/slightlyoff/ServiceWorker/commit/ee62cfc0c450e0522ad7f4944c08f857a4223123

Comment 1

[Cătălin Badea (:catalinb)]

The rename landed in:https://hg.mozilla.org/integration/mozilla-inbound/rev/39354f436e2b

The only thing that's left is implementing the options parameter (selecting uncontrolled clients).

Comment 2

[Cătălin Badea (:catalinb)]

Thanks for taking this bug!

Bug 1130684 adds a set of all opened documents which I believe you can reuse for matchAll.

Comment 3

[Noemí Freire (:noemi)]

in order to fulfill this, service workers should handle the case of having controlled clients such as workers and shared workers, because of this, Bug 1032521 is needed, adding the dependency. Thanks!

Comment 4

[Noemí Freire (:noemi)]

not working on this for the current sprint (FxOS-S2) so releasing it for now to allow anyone else to take it. Thanks!

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

testing/web-platform/mozilla/tests/service-workers/service-worker/clients-matchall-client-types.https.html

should be updated to check the shared worker and all cases (commented out in bug 1189686) when this is fixed.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

All dependents fixed now.

Comment 8

[Chris Mills [:cmills]]

I've just checked, and it looks like we have already documented this sufficiently:
https://developer.mozilla.org/en-US/docs/Web/API/Clients/matchAll

Setting ddn -> ddc.