1133740 - HTML5 input type=number buttons have no accname

Status: NEW

(Core :: Disability Access APIs, defect)

Description

[steve faulkner]

The stepper buttons in the UI of html5 input type number have no accnames

(none) - push button 
MSAA
 accName:;
 accRole:push button;
 accState:normal;
 accDescription:(none);
 accDefaultAction:press;
 accValue:(none);
 IAccessible2
 Name:;
 Role:push button;
 States:Opaque;
 Description:;
 Relation Type:containingDocument
 Relation Targets:input type=number element - document;
 Relation Type:containingTabPane
 Relation Targets:input type=number element - document;
 Relation Type:containingApplication
 Relation Targets:Firefox - application;
 Object Attributes:margin-left:0px, text-align:start, text-indent:0px, formatting:block, margin-right:0px, xml-roles:button, tag:div, margin-top:0px, margin-bottom:0px, display:blockmargin-left:0pxtext-align:starttext-indent:0pxformatting:blockmargin-right:0pxxml-roles:buttontag:divmargin-top:0pxmargin-bottom:0pxdisplay:block


suggest adding accnames to indicate their function

Comment 1

[steve faulkner]

Note: these buttons are included in list/navigation for screen readers such as JAWS 
navigation keys
List Buttons CTRL+INSERT+B
Next Button B
Previous button B

Comment 2

[Marco Zehe (:MarcoZ)]

Thanks, Steve!

Comment 3

[Marco Zehe (:MarcoZ)]

So the role for those pseudo push buttons is set here:
http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsNumberControlFrame.cpp#314

The problem is that, in theory, we'd want to set an aria-label, too, with a dependent string for either increasing or decreasing the number. Problem: That string would have to be localized, or it would always show up in English, which is not what we want.

Comment 4

[Marco Zehe (:MarcoZ)]

Note the reason I'm suggesting aria-label is because we don't want any visual disturbance.

Comment 5

[alexander :surkov (:asurkov)]

cc'ing Olli for localization ideas

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

How do we deal with type="submit" and its a11y + localization?

Comment 7

[Marco Zehe (:MarcoZ)]

(In reply to Olli Pettay [:smaug] from comment #6)
> How do we deal with type="submit" and its a11y + localization?

We pick it up from the visual on-screen text I believe. At least when I use German Firefox, it is definitely localized.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Marco Zehe (:MarcoZ) from comment #7)
> (In reply to Olli Pettay [:smaug] from comment #6)
> > How do we deal with type="submit" and its a11y + localization?
> 
> We pick it up from the visual on-screen text I believe. At least when I use
> German Firefox, it is definitely localized.

right, I guess the question was how that localized text is provided in code. I'm not familiar with that implementation.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

I guess the string could be put here
http://mxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/layout/HtmlForm.properties
and then use that somewhere here
http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsNumberControlFrame.cpp?rev=c36a026244de#314