1142835 - [EME] GMP crash causes Firefox to crash

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Adding an abort() call to ClearKeySessionManager::UpdateSession causes not only the plugin-container to crash, but firefox as well.

[844] WARNING: Trying to use a dead GMP Audio decoder!: file c:\Users\me\src\evil-central\dom\media\gmp\GMPAudioDecoderParent.cpp, line 106
[844] ###!!! ASSERTION: You can't dereference a NULL nsRefPtr with operator->().: 'mRawPtr != 0', file c:\Users\me\src\evil-central\xpcom\base\nsRefPtr.h, line 236

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: adp-assert.patch

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Worth noting that GMPVDP already has this. Must have slipped through the cracks.

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33b68aec2ab9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33b68aec2ab9

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8585245 [details] [diff] [review]
adp-assert.patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Users shouldn't see this, as it's only in debug builds. However if we don't uplift this, we (the developers) will hit crashes when working on aurora/beta trees.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests, which sometimes crash without this patch.
[Risks and why]: Very low; this patch adds null pointer checks to code that only runs in debug builds.
[String/UUID change made/needed]: None.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8585245 [details] [diff] [review]
adp-assert.patch

We want to simplify the life of developers. Taking it. Should be in 38 beta 3
Don't need aurora uplift as it landed before the last merge.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ff855a44d9c