1143987 - EME decoder should be using SharedDecoderManager

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

SharedDecoderManager was disabled when content is encrypted.

With bug 1128381, it is now safe to use SharedDecoderManager with the EME PDM.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Use SharedDecoderManager with EME PDM

Use SDM with EME.

Comment 2

[Jean-Yves Avenard [:jya]]

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/f46c7fbdfb00

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f46c7fbdfb00

Comment 4

[Jean-Yves Avenard [:jya]]

I think this should be uplifted.

we know how much not having dormant on win32 introduced memory issues. Without this we will also have one complete decoder (and all its buffer) per resolution played

Now with EME becoming mainstream, this would greatly help.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8578416 [details] [diff] [review]
Use SharedDecoderManager with EME PDM

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: This patch reduces the number of decoders we potentially create when playing EME video. This potentially will reduce the memory consumption when playing EME videos, and thus reduce the liklihood of out-of-memory crashes.
[Describe test coverage new/current, TreeHerder]: We're shipping this "shared decoder" feature for non-EME video, so it's exercised well there, and of course exercised in our mochitests.
[Risks and why]: Low; potential for breaking decoders, but we've been using this path on non-EME video for a few weeks so we should be OK.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for Aurora uplift.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

I'll take care of it.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3e63e6edecbb