1146733 - [EME] remove PlayFragmented() from eme.js

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

The code is similar of that of AppendTrack() and "fragments" is a special case of multiple tracks. We should remove redundant code for maintainability.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=60641601eedb

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1146733_remove_PlayFragmented-v1.patch

remove redundant code of PlayFragmented().

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8582239 [details] [diff] [review]
1146733_remove_PlayFragmented-v1.patch

Review of attachment 8582239 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/manifest.js
@@ -678,5 @@
>      duration:1.60,
>    },
>    {
>      name:"bipbop-cenc-videoinit.mp4",
> -    type:"video/mp4; codecs=\"avc1.64000d,mp4a.40.2\"",

The type is specified in tracks. Remove this redundant one.

@@ -708,5 @@
>      duration:1.60,
>    },
>    {
>      name:"bipbop-cenc-videoinit.mp4",
> -    type:"video/mp4; codecs=\"avc1.64000d,mp4a.40.2\"",

Ditto.

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8582239 [details] [diff] [review]
1146733_remove_PlayFragmented-v1.patch

Review of attachment 8582239 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/eme.js
@@ -321,1 @@
>      return PlayMultiTrack(test, elem, token);

Seems that LoadTest() is totally superfluous after this. Move the |test.tracks| guard to PlayMultiTrack(), then rename PlayMultiTrack() and remove LoadTest().

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1146733_remove_PlayFragmented-v2.patch

Fix nits suggested in comment 4.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b02e059cf60

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0b02e059cf60