1148568 - Ignore strict errors in JSON.parse with reviver

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

ES6 draft rev 36, 24.3.1.1 InternalizeJSONProperty, specifies that certain errors are ignored.

> 3.  If newElement is undefined, then
>     a.  Let status be val.[[Delete]](ToString(I)).
> 4.  Else
>     a.  Let status be CreateDataProperty(val, ToString(I), newElement).
>     b.  NOTE This algorithm intentionally does not throw an exception
>         if status is false.
> 5.  ReturnIfAbrupt(status).

We already get it right for the deletes, but until bug 1113369 landed, we didn't have a way to do this for the CreateDataProperty call.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: In JSON.parse with a reviver callback, ignore failure when defining properties

Switch to StandardDefineProperty while we're at it. I don't think the "CreateDataProperty" operation given in the spec is quite worth making into a function on its own, since the standard almost exclusively uses it in cases where it "can't fail", and (a) that is unpossible for us; (b) this is not one of those cases anyway.

Comment 2

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f10724b83b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out (along with every other patch from that massive push) in https://hg.mozilla.org/integration/mozilla-inbound/rev/386c8b5b73c0 for talos other timeouts:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3fc49391f7fe&filter-searchStr=talos oth

Comment 4

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdf3d03ce361

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b22618eb4b3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b22618eb4b3