1149398 - Search UI dropdown menu shows search provider buttons even when no search terms have been entered

Status: RESOLVED INVALID

(Firefox :: Search, defect)

Description

[Chris Peterson [:cpeterson]]

Florian, could this bug be a regression from bug 1113747?

If you open the search UI dropdown menu without entering any search terms, the dropdown menu shows the search provider buttons in addition to the "Change Search Settings" button. If you click one of the search provider buttons, Firefox searches for an empty string.

This is a regression in Firefox 38. Firefox 37 just shows the "Change Search Settings" button. I bisected this regression to this pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=56efbd155062&tochange=5de3af90c494

Comment 1

[Chris Peterson [:cpeterson]]

Dao, could this bug be a regression from bug 1113747? It doesn't seem like an intentional design decision.

Comment 2

[Dão Gottwald [:dao]]

This doesn't sound like a bug. You can also just hit Enter in the search bar with no search term entered. It brings you to the search engine's start page.

Comment 3

[Chris Peterson [:cpeterson]]

OK. On further thought, I see how it could be considered a feature. :)

Comment 4

[Florian Quèze [:florian]]

(In reply to Chris Peterson [:cpeterson] from comment #0)

> I bisected this regression to this pushlog:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=56efbd155062&tochange=5de3af90c494

This contains "Bug 1126250 - Show one-off buttons when clicking the magnifying glass" where we implemented this behavior ;-).