1152151 - [EME] Some tests keep working after they should have finished

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Some EME tests keep doing some work after they have first declared themselves finished, e.g.:
https://treeherder.mozilla.org/logviewer.html#?job_id=6292556&repo=try
"23:09:54 INFO - 331 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_eme_canvas_blocked.html | bipbop-cenc-videoinit.mp4-2 fragment 'bipbop-cenc-audio3.m4s' size: expected 977, got 977 - Result logged after SimpleTest.finish()"

This is because "LoadTest(test, v, token)" asynchronously loads all the fragments for each test case, but the test themselves only check pass/fail conditions early (typically after the init segments) and declare the test finished. But loading continues in the background, and some checks are done there, which could result in late errors.

Possible solutions:
1. Don't mark the test 'finished' until loading has completed.
2. Only try to load the segments needed for each test.
3. Allow the test to stop the loading operation.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1152151-eme-test-wait-end-load.patch

Added manager.started(token+"_load") and manager.finished(token+"_load") around TestLoad to ensure that test don't terminate tests too quickly while fetching is still running.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc8db5b4a63b

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2e38cdb64d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for test_eme_persistent_sessions.html timeouts on multiple platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/82fc1964041c

https://treeherder.mozilla.org/logviewer.html#?job_id=8683992&repo=mozilla-inbound

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1152151-eme-test-p1-wait-end-load.patch

Rebase & patch rename, no actual changes, carrying r+.

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1152151-eme-test-p2-minimum-loads.patch

Some tests only need the init fragment and the first data fragment, no need to load more.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c55cbfbc2a24
https://hg.mozilla.org/integration/mozilla-inbound/rev/03406fe40cc9

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3be38a177a9

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c55cbfbc2a24
https://hg.mozilla.org/mozilla-central/rev/03406fe40cc9