1152381 - Implement mediaDevices.getSupportedConstraints()

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

Bug 1152381 - implement mediaDevices.getSupportedConstraints.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Q2 stretch goal. Hopefully trivial.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

https://reviewboard.mozilla.org/r/12495/#review10969

If the ID needs revving, do that

::: dom/media/MediaDevices.h:23
(Diff revision 1)
>   { 0x9a, 0x36, 0x74, 0xa4, 0xd6, 0x71, 0xa6, 0xc8 } }

Do we need to rev this id?

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://reviewboard.mozilla.org/r/12495/#review10969

> Do we need to rev this id?

I'm pretty sure that's only needed by XPCOM not WebIDL. Smaug?

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The reason for doing this ASAP is that the deviceId constraint (Bug 1037389) is tricky to use if you don't know whether the browser supports it or not (e.g. you end up bugging the user about a microphone and/or camera you didn't want, or you have to browser-sniff).

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Webidl doesn't have uuid.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

C++ code should use mozilla coding style, if possible. So, aFoo for argument names?

At least add a comment what are the mozilla specific stuff.
And if possible, add all the properties from the spec to the dictionary, but if they aren't supported, just don't have default value for them.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

Bug 1152381 - implement mediaDevices.getSupportedConstraints.

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://reviewboard.mozilla.org/r/12495/#review10969

> I'm pretty sure that's only needed by XPCOM not WebIDL. Smaug?

Smaug and bz says it's only for c++ users, of which there are none for MediaDevices.

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Put up new webidl version based on feedback from smaug.

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

https://reviewboard.mozilla.org/r/12495/#review11021

Ship It!

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

I see now that the question was about MediaDevices. So if you had added some new virtual methods there or something, the you should have updated the IID.

Comment 13

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

Comment 14

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8628985 [details]
MozReview Request: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

https://reviewboard.mozilla.org/r/12495/#review11025

Ship It!

Comment 15

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Fixed aResult.

Geeen try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=89d663a2fc45

This is ready to go.

Comment 16

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1152381 - implement mediaDevices.getSupportedConstraints. r=smaug, r=jesup

This is the same patch for easy landing.

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a874cf3bf8e

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7a874cf3bf8e