1152602 - Useless counter value in dom/workers/test/serviceworkers/importscript.sjs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

The counter variable there is only ever read from...  Is that test really doing what we want?

Comment 1

[Andrea Marchesini [:baku]]

Attachment: counter.patch

Comment 2

[(no longer active)]

Comment on attachment 8590127 [details] [diff] [review]
counter.patch

Review of attachment 8590127 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/importscript.sjs
@@ +2,5 @@
>  function handleRequest(request, response) {
>    if (!counter) {
>      response.setHeader("Content-Type", "application/javascript", false);
>      response.write("callByScript();");
> +    counter++;

I'm not sure if this does the right thing.  Have you tested this?

As far as I know, global variables are not preserved across sjs runs.  You probably need to use the getState/setState APIs: <https://dxr.mozilla.org/mozilla-central/source/netwerk/test/httpserver/nsIHttpServer.idl#184>

Comment 3

[Andrea Marchesini [:baku]]

Attachment: counter.patch

Comment 4

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89f9815da675

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/89f9815da675