1158463 - Reorder property creation in js::FromPropertyDescriptorToObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

More or less the same as bug 737198, except Object.getOwnPropertyNames instead of Object.keys is used, and ES2015 specifies to preserve property creation order.

Object.getOwnPropertyNames(Object.getOwnPropertyDescriptor({foo: 0}, "foo"))

Expected: [ "value", "writable", "enumerable", "configurable" ]
Actual: [ "configurable", "enumerable", "value", "writable" ]


Object.getOwnPropertyNames(Object.getOwnPropertyDescriptor({get foo(){}}, "foo"))

Expected: [ "get", "set", "enumerable", "configurable" ]
Actual: [ "configurable", "enumerable", "get", "set" ]


ES2015:
6.2.4.4 FromPropertyDescriptor
9.1.12 [[OwnPropertyKeys]] ( )
19.1.2.8.1 Runtime Semantics: GetOwnPropertyKeys ( O, Type )

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: v1 - Use the right property order in FromPropertyDescriptor

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8597610 [details] [diff] [review]
v1 - Use the right property order in FromPropertyDescriptor

Review of attachment 8597610 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_6/Object/property-descriptor-order.js
@@ +11,5 @@
> +        return true;
> +    }
> +});
> +
> +Object.defineProperty(proxy, "foo", {set: function() {}, configurable: true});

Put configurable first, then set second, here -- to verify that we've gone through FromPropertyDescriptor or so here, and aren't simply transliterating directly from the descriptor object provided to Object.defineProperty.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a240e100cb2a

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a240e100cb2a