Closed Bug 1170289 Opened 10 years ago Closed 10 years ago

Move SearchEngineBar's favicons to ImageView

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(3 files)

MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
39 bytes, text/x-review-board-request
Margaret
: review+
Details
MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
39 bytes, text/x-review-board-request
Margaret
: review+
Details
MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret
39 bytes, text/x-review-board-request
Margaret
: review+
Details
FaviconView does inconsistent scaling (bug 1170288) so let's work around it. The Great Antlam says 16dp x 16dp. Be sure to fix the default favicon handling in custom search engines too.
I don't know why I ever used FaviconView when ImageView would do - we should backout bug 1166868 because it adds a lot of unneeded complexity.
(In reply to Michael Comella (:mcomella) from comment #0) > The Great Antlam says 16dp x 16dp. By which I mean 24dp x 24dp, of course.
Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?margaret These patches added complexity that we're removing by implementing this bug.
Bug 1170289 - Set default search engine favicon to magnifying glass. r?margaret This doesn't work for the Settings screen (bug 1170346).
Comment on attachment 8613761 [details] MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret These patches added complexity that we're removing by implementing this bug.
Attachment #8613761 - Attachment description: MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?margaret → MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
Attachment #8613761 - Flags: review?(margaret.leibovic)
Comment on attachment 8613762 [details] MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
Attachment #8613762 - Attachment description: MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?margaret → MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
Attachment #8613762 - Flags: review?(margaret.leibovic)
Comment on attachment 8613763 [details] MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret This doesn't work for the Settings screen (bug 1170346).
Attachment #8613763 - Attachment description: MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?margaret → MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret
Attachment #8613763 - Flags: review?(margaret.leibovic)
Attachment #8613761 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8613761 [details] MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret https://reviewboard.mozilla.org/r/9789/#review8737 Ship It!
Attachment #8613762 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8613762 [details] MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret https://reviewboard.mozilla.org/r/9791/#review8739 Sweet, that's simple :)
Attachment #8613763 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8613763 [details] MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret https://reviewboard.mozilla.org/r/9793/#review8741 Ship It!
https://hg.mozilla.org/mozilla-central/rev/59d01945f35a https://hg.mozilla.org/mozilla-central/rev/822ce15d8b92
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: