1170307 - Use NonNullObject in Debugger.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Calling NonNullObject() is shorter than what we have now.

Also:
-   inline NonNullObject's fast path
-   remove the ^L characters from Debugger.cpp (finally) in favor of
    double blank lines.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jason Orendorff [:jorendorff] from comment #0)
> -   remove the ^L characters from Debugger.cpp (finally) in favor of
>     double blank lines.

Whoa whoa whoa -- these are super useful for code navigation!

Comment 2

[Jason Orendorff [:jorendorff]]

More useful than searching for two blank lines in a row (\n\n\n)? Do you use the ^L support built into emacs?

I'd rather have navigation aids that don't look like some kind of ridiculous mistake to other hackers. They remove them; they don't add new ones when they add new sections...

This is properly a separate bug. though. I'll figure it out with whoever added the form feeds to gc/Marking.cpp and gc/Tracer.cpp.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Inline the common path of NonNullObject; use it instead of ReportObjectRequired in the Debugger

Comment 4

[Shu-yu Guo [:shu]]

Comment on attachment 8627827 [details] [diff] [review]
Inline the common path of NonNullObject; use it instead of ReportObjectRequired in the Debugger

Review of attachment 8627827 [details] [diff] [review]:
-----------------------------------------------------------------

This is nice. Would like the message thing cleared up though.

::: addon-sdk/source/test/test-weak-set.js
@@ +117,5 @@
>  
>    assert.throws(() => {
>      add(items, 'foo');
>    },
> +  /^\w+ is not an object/,

Why the changes to these exception messages? I don't see any changes to messages in this patch.

Comment 5

[Jason Orendorff [:jorendorff]]

I reverted the changes in the addon sdk, as those had to do with changes to js.msg that aren't really necessary.

The current message is dumb, but I can fix it in a later bug.

Comment 6

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2824a3861dd

Comment 7

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9e868f5f61c

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f9e868f5f61c