1173361 - ServiceWorkerRegisterJob::Start() incorrectly calls Done() synchronously

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

While writing the test in bug 1169819 I was able to trigger this assert:

Assertion failure: !mPopping (Pop() called recursively, did you write a job which calls Done() synchronously from Start()?), at /srv/mozilla-central/dom/workers/ServiceWorkerManager.cpp:203
#01: mozilla::dom::workers::ServiceWorkerJob::Done(nsresult) (/srv/mozilla-central/dom/workers/ServiceWorkerManager.cpp:280)
#02: mozilla::dom::workers::ServiceWorkerRegisterJob::Start() (/srv/mozilla-central/dom/workers/ServiceWorkerManager.cpp:781)
#03: mozilla::dom::workers::ServiceWorkerJobQueue::Pop() (/srv/mozilla-central/dom/workers/ServiceWorkerManager.cpp:209)
#04: mozilla::dom::workers::ServiceWorkerJob::Done(nsresult) (/srv/mozilla-central/dom/workers/ServiceWorkerManager.cpp:280)

This is caused by ServiceWorkerRegisterJob::Start() calling Done() synchronously.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make ServiceWorkerRegisterJob::Start() call Done() async. r=nsm

Comment 2

[Noemí Freire (:noemi)]

setting v1 dependency. Thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fba915650d9

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8fba915650d9