1173378 - crash in mozilla::net::HttpBaseChannel::OverrideSecurityInfo(nsISupports*)

Status: VERIFIED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

This bug was filed from the Socorro interface and is 
report bp-30490d4c-171c-42c3-8e9d-9ba232150610.
=============================================================

I got this crash when I was testing trained to thrill.

Comment 1

[(no longer active)]

So far I have been unable to reproduce this under the debugger to see exactly what is going on...

Michal, since you asked me to turn this assertions to release asserts in bug 1133763 comment 59, does the fact that this assertion can be hit in practice change your mind?  I don't think this is something that we should crash on...

Comment 2

[Michal Novotny [:michal]]

Agree, we shouldn't crash on this, but we also shouldn't silently ignore the unexpected state in release build. So what about failing here and keeping just a debug assertion?

Comment 3

[(no longer active)]

That sounds good to me!

Comment 4

[(no longer active)]

Attachment: Relax the release assertions for the service worker URI and security info overrides into debug mode assertions

Comment 5

[Michal Novotny [:michal]]

Attachment: patch

I meant something like this.

Comment 6

[(no longer active)]

Comment on attachment 8622089 [details] [diff] [review]
patch

Review of attachment 8622089 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, looks sane!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e5641d6cd6f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2e5641d6cd6f

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Socorro [1] shows zero crashes over the past 4 weeks in builds that contain the fix.

[1] - https://crash-stats.mozilla.com/report/list?range_unit=days&range_value=28&signature=mozilla%3A%3Anet%3A%3AHttpBaseChannel%3A%3AOverrideSecurityInfo%28nsISupports%2A%29#tab-reports